Repository navigation
Conversation
- release request and task transactions across graphs - protect scan callbacks until Store shutdown completes - cover lifecycle boundaries with regression tests - document shutdown behavior and timeout diagnosis
- keep caller transactions open when traversers close - rollback failed worker transactions and reset thread state - run Store shutdown tests through the active Maven suite - cover task commit and cleanup with real RocksDB tests
- require the central server profile and test report - verify every selected Store profile has a session - retain strict execution order and coverage checks
- reject interrupted scans without partial success - wake closed channels without interrupting RPC callers - verify cancellation status through active scan paths - retain library and executable Node artifacts
- expose stop diagnostics from smoke cleanup - preserve failure status and retained PID evidence - retain existing native shutdown timeout
- include the merged runtime alignment - retain lifecycle changes as a separate PR - inherit current upstream CI configuration - preserve both upgrade and lifecycle documentation
- keep the ordinary code margin at 120 columns - allow Markdown paragraphs without hard wrapping - show a 160-column Markdown visual guide - align CodeRabbit instructions with repository style
- separate response completion from resource release - isolate cancellation callback failures - preserve native iterator close failures - transfer iterator ownership before prefetch - cover Spring shutdown and real JNI boundaries
- Keep the newest run for each workflow and PR - Verify source freshness before automatic retries - Test retry decisions and document the CI policy
- Keep one active run per workflow and PR - Preserve push and manual workflow executions - Cover CI workflows on this PR target branch
- Reserve the exec classifier for distribution assembly - Avoid compile-time resolution of packaged artifacts - Keep the existing assembly filename and runtime inclusion
- separate natural completion from cancellation - retain failed cleanup owners until retry succeeds - close nested scan iterators and serialize receipts - verify cancellation and ordered scan backpressure
- deliver credit-backed results after request half-close - cancel client streams when iterators close early - preserve queued final results across completion races - verify matched client and server stream behavior
- report outstanding scan count at the wait interval - retain details only for actual cleanup failures - preserve shutdown waits and interrupt handling
- preserve cancellation precedence in terminal callbacks - finish cancelled scans after automatic iterator cleanup - cover blocked close with callback and unary gRPC tests - document cancellation and retain native drain ownership
- capture the observed wait state before asserting - retain database and failed-cleanup ownership checks - verify scan and aggregate shutdown regressions
- adopt the Java 17 baseline - retain Gremlin and lifecycle semantics - preserve both test-suite additions
- propagate transport cancellation independently - reject repeated queries before iterator allocation - cover real cancellation and single terminal callbacks - document request and response lifecycle boundaries
- wait until response callback is in flight - trigger cleanup failure in the intended order - preserve worker ownership and terminal assertions
- close write batch and options at final detach - retain owners while another lease is active - guarantee both disposal attempts and closed state - cover real JNI owners across repeated worker requests
- select supported auth fixtures by actual graph backend - run cleanup assertions without a backend system property - give the OLAP sentinel fixture a valid vertex ID - assert the intended schema rejection source
- retain schema identity across request cleanup - keep cache invalidation listeners until graph close - dispose only the matching graph listener generation - cover schema append and API update regressions
- observe normal sender completion before teardown - avoid inline transport cancellation during completion - retain early cancel and resource release assertions
- check published terminal state before timed poll - preserve final-batch queue visibility ordering - cover exhausted single and merged streams - register the regression in the client suite
- detach owned store listeners without a cache holder - preserve reopened listener generation ownership - clear auth projects using the actual graph backend - retain reopen failures and clean temporary data
- propagate transaction cleanup failures after all owners close - retain graph-scoped schema cache listeners - cancel all started result streams on close - register graph scans for deterministic shutdown cleanup
- retain merged Topling and shared schema behavior - drain Store streams before storage shutdown - preserve cleanup failures and update regressions
- exclude HTTP libraries from Node test dependency - preserve production dependencies and security gate - verify Store lifecycle tests without web jars
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3294 +/- ##
============================================
+ Coverage 41.42% 41.62% +0.19%
- Complexity 6931 6979 +48
============================================
Files 762 762
Lines 66773 66803 +30
Branches 8939 8948 +9
============================================
+ Hits 27662 27804 +142
+ Misses 35957 35824 -133
- Partials 3154 3175 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
16 of 69 tasks
5 of 12 tasks
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests can leave scan work or native resources alive after cancellation, and Store can close its engine before in-flight RPCs finish. This change releases request-owned resources on failure/cancellation and drains Store RPC work before storage shutdown.
Based on current Apache master, including the merged ToplingDB integration. This is a general lifecycle fix for Server/Store; it does not add a provider or change how users switch to ToplingDB. Changes already merged in apache/hugegraph#3275 are retained rather than duplicated.
Validation: Java 17 full-repository compilation and focused transaction, scan, cancellation, shutdown and legacy serialization regressions pass. Existing review threads are resolved; CI for this updated commit remains to be confirmed. See
docs/transaction-lifecycle.mdfor lifecycle behavior.Doc - Done.